Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: passing dependency for asyncdestinationmanager #5080

Merged
merged 1 commit into from
Sep 11, 2024
Merged

chore: passing dependency for asyncdestinationmanager #5080

merged 1 commit into from
Sep 11, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Sep 11, 2024 •
edited
Loading

Description

  • Passing dependency for config, logger and stats instead of global default for asyncdestinationmanager package.
  • It's a preliminary PR for the changes I am making around snowpipe streaming in asyncdestinationmanager.

Linear Ticket

  • Resolves PIPE-1511

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@achettyiitr achettyiitr force-pushed the chore.asyncdestinationmanager-passing-dependency branch from 55254fd to 3026d4c Compare September 11, 2024 06:43
@achettyiitr achettyiitr force-pushed the chore.asyncdestinationmanager-passing-dependency branch from 3026d4c to d52b86c Compare September 11, 2024 06:53
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 51.02041% with 48 lines in your changes missing coverage. Please review.

Project coverage is 74.74%. Comparing base (9a4b843) to head (d52b86c).

Files with missing lines Patch % Lines
...ter/batchrouter/asyncdestinationmanager/manager.go 0.00% 13 Missing ⚠️
...onmanager/marketo-bulk-upload/marketobulkupload.go 0.00% 10 Missing ⚠️
...yncdestinationmanager/bing-ads/audience/manager.go 28.57% 5 Missing ⚠️
...ionmanager/bing-ads/offline-conversions/manager.go 28.57% 5 Missing ⚠️
...tionmanager/klaviyobulkupload/klaviyobulkupload.go 42.85% 4 Missing ⚠️
...atchrouter/asyncdestinationmanager/sftp/manager.go 63.63% 4 Missing ⚠️
...chrouter/asyncdestinationmanager/eloqua/manager.go 50.00% 3 Missing ⚠️
...ncdestinationmanager/lytics_bulk_upload/manager.go 60.00% 2 Missing ⚠️
...tionmanager/lytics_bulk_upload/lyticsBulkUpload.go 66.66% 1 Missing ⚠️
router/batchrouter/handle_lifecycle.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5080      +/-   ##
==========================================
- Coverage   74.76%   74.74%   -0.02%     
==========================================
  Files         435      435              
  Lines       50369    50378       +9     
==========================================
- Hits        37659    37657       -2     
- Misses      10243    10255      +12     
+ Partials     2467     2466       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit f6271a0 into master Sep 11, 2024
63 checks passed
@achettyiitr achettyiitr deleted the chore.asyncdestinationmanager-passing-dependency branch September 11, 2024 14:41
This was referenced Sep 16, 2024
Closed
Closed
Closed
@mihir20 mihir20 mentioned this pull request Sep 16, 2024
Merged
This was referenced Sep 16, 2024
Closed
Closed
Closed
Closed
Closed
@Sidddddarth Sidddddarth mentioned this pull request Sep 17, 2024
Merged
1 task
This was referenced Sep 17, 2024
Closed
Closed
Merged
Merged
Merged
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@lvrach lvrach lvrach approved these changes

@Gauravudia Gauravudia Awaiting requested review from Gauravudia

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@ktgowtham ktgowtham Awaiting requested review from ktgowtham

@cisse21 cisse21 Awaiting requested review from cisse21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achettyiitr @lvrach @koladilip